Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): disallow TSInstantiationExpression in SimpleAssignmentTarget #9586

Merged
merged 1 commit into from
Mar 7, 2025
Merged

feat(parser): disallow TSInstantiationExpression in SimpleAssignmentTarget #9586

merged 1 commit into from
Mar 7, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Mar 7, 2025

relates #9493

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST A-codegen Area - Code Generation A-prettier Area - Prettier C-enhancement Category - New feature or request labels Mar 7, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Mar 7, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9586 will not alter performance

Comparing 03-07-feat_parser_disallow_tsinstantiationexpression_in_simpleassignmenttarget_ (6b95d25) with main (f82cbee)

Summary

✅ 39 untouched benchmarks

@Boshen Boshen force-pushed the 03-07-feat_parser_disallow_tsinstantiationexpression_in_simpleassignmenttarget_ branch from 309f0cb to 0b4d237 Compare March 7, 2025 09:15
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 7, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 7, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 03-07-feat_parser_disallow_tsinstantiationexpression_in_simpleassignmenttarget_ branch from 0b4d237 to 6b95d25 Compare March 7, 2025 09:21
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 7, 2025
@graphite-app graphite-app bot merged commit 6b95d25 into main Mar 7, 2025
34 checks passed
@graphite-app graphite-app bot deleted the 03-07-feat_parser_disallow_tsinstantiationexpression_in_simpleassignmenttarget_ branch March 7, 2025 09:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 7, 2025
This was referenced Mar 7, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen