Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): move rule no-restricted-imports to category restriction #9443

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Feb 28, 2025

it was moved from style to nursery here #7897
I think restriction is a better place?

Copy link
Collaborator Author

Sysix commented Feb 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 28, 2025
@Sysix Sysix marked this pull request as ready for review February 28, 2025 14:45
Copy link

codspeed-hq bot commented Feb 28, 2025

CodSpeed Performance Report

Merging #9443 will not alter performance

Comparing 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ (7c27f10) with main (d43b456)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix force-pushed the 02-28-fix_linter_rule_no-restricted-imports_use_right_span_for_exports_statements branch from d265daa to 41b5ba3 Compare February 28, 2025 16:00
@Sysix Sysix force-pushed the 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ branch from ffb5c12 to 822551f Compare February 28, 2025 16:00
@Sysix Sysix force-pushed the 02-28-fix_linter_rule_no-restricted-imports_use_right_span_for_exports_statements branch from c931768 to 2d1a0ce Compare February 28, 2025 16:05
@Sysix Sysix force-pushed the 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ branch from 7c4ebaa to 44687a1 Compare February 28, 2025 16:05
@Sysix Sysix force-pushed the 02-28-fix_linter_rule_no-restricted-imports_use_right_span_for_exports_statements branch from 2d1a0ce to b3d45fe Compare February 28, 2025 20:59
@Sysix Sysix force-pushed the 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ branch from 44687a1 to 6a54a4b Compare February 28, 2025 20:59
@Sysix Sysix force-pushed the 02-28-fix_linter_rule_no-restricted-imports_use_right_span_for_exports_statements branch from b3d45fe to f800982 Compare February 28, 2025 21:11
@Sysix Sysix force-pushed the 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ branch from 6a54a4b to 38d1abd Compare February 28, 2025 21:11
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 1, 2025
Copy link
Member

Boshen commented Mar 1, 2025

Merge activity

  • Feb 28, 8:14 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 28, 8:14 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 28, 8:26 PM EST: A user merged this pull request with the Graphite merge queue.

…riction` (#9443)

it was moved from style to nursery here #7897
I think restriction is a better place?
@graphite-app graphite-app bot force-pushed the 02-28-fix_linter_rule_no-restricted-imports_use_right_span_for_exports_statements branch from f800982 to 06fe76d Compare March 1, 2025 01:15
@graphite-app graphite-app bot force-pushed the 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ branch from 38d1abd to 7c27f10 Compare March 1, 2025 01:16
Base automatically changed from 02-28-fix_linter_rule_no-restricted-imports_use_right_span_for_exports_statements to main March 1, 2025 01:23
@graphite-app graphite-app bot merged commit 7c27f10 into main Mar 1, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-28-refactor_linter_move_rule_no-restricted-imports_to_category_restriction_ branch March 1, 2025 01:26
Boshen added a commit that referenced this pull request Mar 4, 2025
## [0.15.13] - 2025-03-04

### Features

- 7bb0121 linter: Add `react/no-namespace` (#9404) (Mikhail Baev)
- 0a7ca20 linter: Support allowable method diagnostic for
eslint/no-console (#9454) (Boshen)
- d99bc51 linter: Add import/no-absolute-path rule (#9415) (yefan)
- 8c71590 linter: Add import/no-mutable-exports rule (#9434) (yefan)
- b65f8a5 linter: Add `promise/no-nesting` (#9345) (Tom)
- d38e6de linter: Add `eslint/no-spaced-func` (#9360) (Tom)
- 25392de linter: Add eslint/operator-assignment rule (#9208) (yefan)
- bf77167 linter: Add `curly` rule (#8123) (Yuichiro Yamashita)
- e3b6eeb linter: Add `unicorn/consistent-date-clone` (#9346) (Amol
Bhave)
- 5ee2cab linter: Improve no_invalid_fetch_options (#9347)
(Brooooooklyn)
- 4ad328b linter: Add oxc/no-redundant-constructor-init (#9299) (Ben
Jones)

### Bug Fixes

- c4624a6 linter: Fix panic in `import/no-absolute-path` (#9500)
(camc314)
- 4b0327b linter: False positive in `eslint/curly` (#9471) (Kevin Deng
三咲智子)
- 8804555 linter: Skip `no-absolute-path` tests on windows (#9435)
(Cameron)
- 06fe76d linter: Rule `no-restricted-imports` use right span for
exports statements (#9442) (Sysix)
- 3da3565 linter: Rule `unicorn/no-invalid-fetch-options` (#9416) (Tom)
- 85fbe8c linter: Rule `eslint/radix` look into globals config (#9407)
(Sysix)
- 1113e3b linter: Rule `eslint/no-object-constructor` look into globals
config (#9406) (Sysix)
- 0217ebb linter: Support more cases for no_redundant_constructor_init
(#9364) (Ben Jones)

### Documentation

- 24850e7 linter: Add example of how configure rule (#9469) (Cédric
DIRAND)
- acb1e2c linter: Add end code tag on rule doc (#9470) (Cédric DIRAND)
- d43b456 linter: Add full documentation to rule `no-restricted-imports`
(#9440) (Sysix)

### Refactor

- ffec3f6 linter: Improve `eslint/no-new` (#9423) (Tom)
- 7c27f10 linter: Move rule `no-restricted-imports` to category
`restriction` (#9443) (Sysix)
- 7e118a3 linter: Improve `typescript/explicit-function-return-type`
(#9439) (Tom)
- 5318cf2 linter: Improve `eslint/no-spaced-func` (#9419) (shulaoda)
- 802f00e linter: Use the `javascript-globals` crate (#9412) (Boshen)
- bff83c9 linter: Improve `eslint/no-unsafe-negation` (#9362) (dalaoshu)
- 228bf99 linter: Improve `unicorn/empty-brace-spaces` (#9341)
(dalaoshu)
- 55d071b linter: Improve `unicorn/consistent-existence-index-check`
(#9339) (dalaoshu)
- 17acece linter: Improve `eslint/no-template-curly-in-string` (#9090)
(dalaoshu)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants