Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add unicorn/no-invalid-fetch-options rule #9212

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

baevm
Copy link
Contributor

@baevm baevm commented Feb 18, 2025

This PR implements unicorn/no-invalid-fetch-options rule

issue: #684

@github-actions github-actions bot added the A-linter Area - Linter label Feb 18, 2025
Copy link

graphite-app bot commented Feb 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Feb 18, 2025
@shulaoda shulaoda force-pushed the no-invalid-fetch-options branch from 16d816e to 7ffc1c3 Compare February 19, 2025 15:12
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #9212 will not alter performance

Comparing baevm:no-invalid-fetch-options (7717dfe) with main (af13b1b)

Summary

✅ 33 untouched benchmarks

@shulaoda shulaoda requested a review from Sysix February 19, 2025 15:25
@github-actions github-actions bot added the A-cli Area - CLI label Feb 19, 2025
@shulaoda shulaoda force-pushed the no-invalid-fetch-options branch from a63a772 to 0ae3aef Compare February 19, 2025 15:28
@shulaoda
Copy link
Member

LGTM! Thanks!

@Sysix Sysix merged commit cc8dd48 into oxc-project:main Feb 19, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants