Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support import-x plugin name #9074

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Feb 12, 2025

closes #8779

The import-x rules are the reimplementation of the import rules. No rules added or removed.
Some eslint-plugins/configs are handling the plugin the same way.

Here a snippet from a config which next-auth is using:
https://github.com/antfu/eslint-config/blob/998887cedb0b09c5b95d08602689a2c86e6662c7/src/factory.ts#L56-L67

Could not find more places where some mapping is happening. Please have a look because I did not test it.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 12, 2025
Copy link
Collaborator Author

Sysix commented Feb 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review February 12, 2025 17:59
Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #9074 will not alter performance

Comparing 02-12-feat_linter_support_import-x_plugin_name (542bbd7) with main (d266c29)

Summary

✅ 33 untouched benchmarks

@Sysix Sysix requested a review from Boshen February 15, 2025 17:40
@Sysix Sysix force-pushed the 02-12-feat_linter_support_import-x_plugin_name branch from 8f72834 to 0e5fe19 Compare February 18, 2025 19:38
@github-actions github-actions bot added the A-cli Area - CLI label Feb 18, 2025
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Feb 18, 2025
Copy link
Collaborator Author

Sysix commented Feb 18, 2025

Merge activity

  • Feb 18, 2:39 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 18, 2:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 18, 2:48 PM EST: A user merged this pull request with the Graphite merge queue.

@Sysix
Copy link
Collaborator Author

Sysix commented Feb 18, 2025

closes #8779

The `import-x` rules are the reimplementation of the `import` rules. No rules added or removed.
Some eslint-plugins/configs are handling the plugin the same way.

Here a snippet from a config which `next-auth` is using:
https://github.com/antfu/eslint-config/blob/998887cedb0b09c5b95d08602689a2c86e6662c7/src/factory.ts#L56-L67

Could not find more places where some mapping is happening. Please have a look because I did not test it.
@graphite-app graphite-app bot force-pushed the 02-12-feat_linter_support_import-x_plugin_name branch from 0e5fe19 to 542bbd7 Compare February 18, 2025 19:44
@graphite-app graphite-app bot merged commit 542bbd7 into main Feb 18, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-12-feat_linter_support_import-x_plugin_name branch February 18, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oxlint: Support eslint-plugin-import-x rules
2 participants