Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformer/typescript): correct the semantic for TSImportEqualsDeclaration transformation #8463

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(transformer/typescript): correct the semantic for TSImportEqualsDeclaration transformation #8463

merged 1 commit into from
Jan 14, 2025

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 13, 2025

No description provided.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Jan 13, 2025
@Dunqing Dunqing mentioned this pull request Jan 13, 2025
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Jan 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Jan 13, 2025
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8463 will not alter performance

Comparing 01-13-fix_transformer_typescript_correct_the_semantic_for_tsimportequalsdeclaration_transformation (270245f) with main (2a400d6)

Summary

✅ 32 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Jan 14, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 14, 4:40 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 14, 4:40 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 14, 4:40 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8460.
  • Jan 14, 5:55 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 14, 6:09 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 14, 6:09 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 14, 6:09 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 14, 6:09 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 14, 6:27 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 14, 6:31 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 14, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2025
Base automatically changed from 01-13-fix_transformer_typescript_retain_tsimportequalsdeclaration_when_it_is_exported to graphite-base/8460 January 14, 2025 11:09
@graphite-app graphite-app bot changed the base branch from graphite-base/8460 to main January 14, 2025 11:09
@Boshen Boshen force-pushed the 01-13-fix_transformer_typescript_correct_the_semantic_for_tsimportequalsdeclaration_transformation branch 2 times, most recently from f9fed29 to 53dec04 Compare January 14, 2025 11:22
@Boshen Boshen force-pushed the 01-13-fix_transformer_typescript_correct_the_semantic_for_tsimportequalsdeclaration_transformation branch from 53dec04 to 270245f Compare January 14, 2025 11:26
@graphite-app graphite-app bot merged commit 270245f into main Jan 14, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 01-13-fix_transformer_typescript_correct_the_semantic_for_tsimportequalsdeclaration_transformation branch January 14, 2025 11:31
@oxc-bot oxc-bot mentioned this pull request Jan 14, 2025
Merged
Boshen added a commit that referenced this pull request Jan 14, 2025
@oxc-bot @Boshen
release(crates): v0.46.0 (#8487)
3e05055 
## [0.46.0] - 2025-01-14

- 7eb6ccd ast: [**BREAKING**] Remove unused and not useful `ContentHash`
(#8483) (Boshen)

### Features

- 8accfef minifier: Minify `var x; void x` -> `void 0` (#8466) (Boshen)
- 870a583 minifier: Fold `false['toString']` (#8447) (Boshen)
- 4ad695d napi/minify: Implement napi (#8478) (Boshen)
- 9d550aa span: Add `Atom::r#static` (#8479) (_Kerman)

### Bug Fixes

- 4071878 isolated-declarations: Retain `declare` declarations when they
are exported (#8477) (Dunqing)
- 7ee7634 isolated-declarations: Import statement disappears when import
binding is referenced in nested `typeof` (#8476) (Dunqing)
- 7252cb0 isolated-declarations: Unexpected error when global `Symbol`
as property key (#8475) (Dunqing)
- 4c6675c minifier: Do not convert while to fors in DCE (#8484) (Boshen)
- 1d6e84d minifier: Fix incorrect `null.toString()` and `1n.toString()`
(#8464) (Boshen)
- 25d4bf9 minifier: Remove usage of empty spans (#8462) (Boshen)
- dd64340 minifier: Keep `return undefined` in async generator function
(#8439) (Boshen)
- c444de8 transformer/arrow-functions: Transform `this` and `super`
incorrectly in async arrow function (#8435) (Dunqing)
- 270245f transformer/typescript: Correct the semantic for
TSImportEqualsDeclaration transformation (#8463) (Dunqing)
- 2a400d6 transformer/typescript: Retain TSImportEqualsDeclaration when
it is exported (Dunqing)
- ab694b0 transformer/typescript: Retain `TSImportEqualsDeclaration` in
`namespace` when its binding has been referenced or
`onlyRemoveTypeImports` is true (#8458) (Dunqing)

### Performance

- 7a8200c mangler: Allocate base54 name without heap allocation (#8472)
(Boshen)
- 31dac22 mangler: Allocate data in arena (#8471) (Boshen)
- 8fc238a minifier: Merge `Normalize` and `RemoveSyntax` pass (#8467)
(Boshen)
- 372eb09 minifier: Preallocate mangler's semantic data (#8451) (Boshen)

### Refactor

- 6e64eef codegen: Remove `match_expression!` (#8450) (Boshen)
- de5b288 span: Rename `Atom::new_const` method (#8480) (overlookmotel)
- c83ce5c transformer/typescript: Improve transforming namespace (#8459)
(Dunqing)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @Boshen