Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(napi): simplify + reformat README #6834

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 23, 2024

In particular:

  • the long comment was scrolling off side of screen on npm.com.
  • the example is ESM, so can simplify it by using top level await.

Copy link

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Oct 23, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 23, 2024 17:17
@overlookmotel overlookmotel requested a review from Boshen October 23, 2024 17:17
@Boshen Boshen merged commit d48e008 into main Oct 24, 2024
6 checks passed
@Boshen Boshen deleted the 10-23-docs_napi_simplify_reformat_readme branch October 24, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants