Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(traverse): BoundIdentifier methods only take &TraverseCtx #6811

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 23, 2024

These methods don't require a &mut TraverseCtx, as they only call methods on AstBuilder.

Copy link

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Oct 23, 2024

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 23, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 23, 2024 10:54
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #6811 will not alter performance

Comparing 10-23-refactor_traverse_boundidentifier_methods_only_take_traversectx_ (47bc368) with main (55c07f2)

Summary

✅ 30 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

Minor change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 23, 2024
Copy link
Contributor Author

overlookmotel commented Oct 23, 2024

Merge activity

  • Oct 23, 7:31 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 23, 7:31 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 23, 7:36 AM EDT: A user merged this pull request with the Graphite merge queue.

#6811)

These methods don't require a `&mut TraverseCtx`, as they only call methods on `AstBuilder`.
@overlookmotel overlookmotel force-pushed the 10-23-refactor_traverse_boundidentifier_methods_only_take_traversectx_ branch from fd395a5 to 47bc368 Compare October 23, 2024 11:32
@graphite-app graphite-app bot merged commit 47bc368 into main Oct 23, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-23-refactor_traverse_boundidentifier_methods_only_take_traversectx_ branch October 23, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant