Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): remove some broken cases #6797

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/oxc_codegen/examples/codegen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ fn main() -> std::io::Result<()> {

let Some(ret) = parse(&allocator, &printed, source_type) else { return Ok(()) };
println!("Second time:");
let printed = codegen(&ret, minify);
println!("{printed}");
let printed2 = codegen(&ret, minify);
println!("{printed2}");
// Check syntax error
parse(&allocator, &printed, source_type);
parse(&allocator, &printed2, source_type);
println!("same = {}", printed == printed2);
}

Ok(())
Expand Down
55 changes: 2 additions & 53 deletions tasks/coverage/snapshots/runtime.snap
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
commit: 06454619

runtime Summary:
AST Parsed : 18480/18480 (100.00%)
Positive Passed: 17199/18480 (93.07%)
AST Parsed : 18446/18446 (100.00%)
Positive Passed: 17182/18446 (93.15%)
tasks/coverage/test262/test/annexB/language/function-code/block-decl-func-block-scoping.js
minify error: ReferenceError: f is not defined

Expand Down Expand Up @@ -1536,9 +1536,6 @@ transform error: ReferenceError: require is not defined
tasks/coverage/test262/test/language/expressions/class/elements/gen-private-method-static/yield-spread-obj.js
transform error: ReferenceError: require is not defined

tasks/coverage/test262/test/language/expressions/class/elements/syntax/valid/grammar-field-accessor.js
codegen error: SyntaxError: Unexpected identifier '$'

tasks/coverage/test262/test/language/expressions/class/gen-method/yield-spread-obj.js
transform error: ReferenceError: require is not defined

Expand All @@ -1548,39 +1545,6 @@ transform error: ReferenceError: require is not defined
tasks/coverage/test262/test/language/expressions/class/name.js
minify error: Test262Error: descriptor value should be cls; object value should be cls

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--1.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--11.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--13.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--15.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--17.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--19.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--21.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--3.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--5.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--7.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v--9.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/conditional/in-branch-1.js
minify error: Test262Error: Expected SameValue(«0», «1») to be true

Expand Down Expand Up @@ -2121,18 +2085,6 @@ minify error: Test262Error: Expected a SyntaxError to be thrown but no exception
tasks/coverage/test262/test/language/expressions/optional-chaining/member-expression.js
minify error: Test262Error: Expected SameValue(«"a"», «"m"») to be true

tasks/coverage/test262/test/language/expressions/postfix-decrement/operator-x-postfix-decrement-calls-putvalue-lhs-newvalue--1.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/postfix-increment/operator-x-postfix-increment-calls-putvalue-lhs-newvalue--1.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/prefix-decrement/operator-prefix-decrement-x-calls-putvalue-lhs-newvalue--1.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/prefix-increment/operator-prefix-increment-x-calls-putvalue-lhs-newvalue--1.js
codegen error: Test262Error: Expected a ReferenceError but got a TypeError

tasks/coverage/test262/test/language/expressions/subtraction/S11.6.2_A4_T5.js
minify error: Test262Error: #3.2: -0 - 0 === - 0. Actual: +0

Expand Down Expand Up @@ -3135,9 +3087,6 @@ transform error: ReferenceError: require is not defined
tasks/coverage/test262/test/language/statements/class/elements/private-setter-visible-to-direct-eval.js
minify error: ReferenceError: v is not defined

tasks/coverage/test262/test/language/statements/class/elements/syntax/valid/grammar-field-accessor.js
codegen error: SyntaxError: Unexpected identifier '$'

tasks/coverage/test262/test/language/statements/class/gen-method/yield-spread-obj.js
transform error: ReferenceError: require is not defined

Expand Down
10 changes: 9 additions & 1 deletion tasks/coverage/src/runtime/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ static SKIP_FEATURES: &[&str] = &[
"array-grouping",
// stage 2
"Intl.DurationFormat",
// stage 3
"decorators",
];

static SKIP_INCLUDES: &[&str] = &[
Expand All @@ -67,6 +69,12 @@ static SKIP_TEST_CASES: &[&str] = &[
// Properly misconfigured test setup for `eval`, but can't figure out where
"annexB/language/eval-code",
"language/eval-code",
// formerly S11.13.2_A5.10_T5
"language/expressions/compound-assignment/compound-assignment-operator-calls-putvalue-lref--v",
"language/expressions/postfix-increment/operator-x-postfix-increment-calls-putvalue-lhs-newvalue",
"language/expressions/postfix-decrement/operator-x-postfix-decrement-calls-putvalue-lhs-newvalue",
"language/expressions/prefix-increment/operator-prefix-increment-x-calls-putvalue-lhs-newvalue",
"language/expressions/prefix-decrement/operator-prefix-decrement-x-calls-putvalue-lhs-newvalue",
];

pub struct Test262RuntimeCase {
Expand Down Expand Up @@ -230,7 +238,7 @@ async fn request_run_code(json: impl serde::Serialize + Send + 'static) -> Resul
tokio::spawn(async move {
agent()
.post("http://localhost:32055/run")
.timeout(Duration::from_secs(2))
.timeout(Duration::from_secs(4))
.send_json(json)
.map_err(|err| err.to_string())
.and_then(|res| res.into_string().map_err(|err| err.to_string()))
Expand Down
6 changes: 3 additions & 3 deletions tasks/coverage/src/runtime/runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ const server = createServer((req, res) => {
try {
await runCodeInHarness(options);
} catch (err) {
if (parseInt(process.version.split('.')[0].replace('v', '')) < 20) {
return res.end('Please upgrade the Node.js version to 20 or later.');
if (parseInt(process.version.split('.')[0].replace('v', '')) < 22) {
return res.end('Please upgrade the Node.js version to 22 or later.');
}
return res.end(err.toString());
}
Expand All @@ -150,6 +150,6 @@ process.on('unhandledRejection', () => {
// Don't exit when a test does this
});

server.timeout = 2000;
server.timeout = 3000;

server.listen(32055, () => {});
Loading