perf(minifier): InjectGlobalVariables only add to replaced_dot_defines once for each
#4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #4803 will not alter performanceComparing Summary
|
Merge activity
|
…ines` once for each (#4803) `InjectGlobalVariables` minifier plugin was previously adding an entry to `replaced_dot_defines` each time it made a replacement, resulting in many duplicate entries if a single dot define gets replaced multiple times. Only add once for each dot define.
Boshen
force-pushed
the
08-10-perf_minifier_avoid_repeated_atom_creation_in_injectglobalvariables_
branch
from
08bba4f to
35f2742
Compare
Boshen
force-pushed
the
08-10-perf_minifier_injectglobalvariables_only_add_to_replaced_dot_defines_once_for_each
branch
from
a03421f to
504ac0b
Compare
Base automatically changed from
08-10-perf_minifier_avoid_repeated_atom_creation_in_injectglobalvariables_
to
main
August 10, 2024 13:49
graphite-app
bot
deleted the
08-10-perf_minifier_injectglobalvariables_only_add_to_replaced_dot_defines_once_for_each
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 12, 2024
## [0.24.2] - 2024-08-12 ### Features - 8e10e25 allocator: Introduce `Address` (#4810) (overlookmotel) ### Bug Fixes - 62f759c transformer/typescript: Generated assignment for constructor arguments with access modifiers should be injected to the top of the constructor (#4808) (Dunqing) ### Performance - 504ac0b minifier: `InjectGlobalVariables` only add to `replaced_dot_defines` once for each (#4803) (overlookmotel) - 35f2742 minifier: Avoid repeated `Atom` creation in `InjectGlobalVariables` (#4802) (overlookmotel) ### Documentation - 8827659 ast: More doc comments for JSX nodes (#4830) (DonIsaac) - 559baa5 parser: Clean up doc regarding performance; remove conformance (Boshen) ### Refactor - 0ea697b ast, ast_codegen: `CloneIn` implementations now initialize semantic related cells with `Default` value. (#4819) (rzvxa) - ecfa124 ast_codegen: Add line break to generated code (#4829) (overlookmotel) - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InjectGlobalVariablesminifier plugin was previously adding an entry toreplaced_dot_defineseach time it made a replacement, resulting in many duplicate entries if a single dot define gets replaced multiple times. Only add once for each dot define.