Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(semantic/cfg): better control flow for ForStatements. #3453

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented May 28, 2024

similar to #3451 and #3452

Copy link

graphite-app bot commented May 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-semantic Area - Semantic label May 28, 2024
Copy link

codspeed-hq bot commented May 28, 2024

CodSpeed Performance Report

Merging #3453 will degrade performances by 3.51%

Comparing 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s (ff3f37d) with main (646b993)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s Change
transformer[RadixUIAdoptionSection.jsx] 286.1 µs 268.2 µs +6.7%
transformer[pdf.mjs] 61 ms 63.2 ms -3.51%

@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 384a918 to 22a4d11 Compare May 28, 2024 13:24
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from b9dd385 to 14043dd Compare May 28, 2024 13:24
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 22a4d11 to dc06e60 Compare May 28, 2024 13:30
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from 14043dd to 658e5d5 Compare May 28, 2024 13:30
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from dc06e60 to 620cab3 Compare May 28, 2024 14:48
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from 658e5d5 to ae657bc Compare May 28, 2024 14:48
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 620cab3 to 2bfaa6d Compare May 28, 2024 18:06
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from ae657bc to 857840a Compare May 28, 2024 18:06
@rzvxa rzvxa marked this pull request as ready for review May 30, 2024 20:36
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 2bfaa6d to 33b9fcc Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from 857840a to 3482d50 Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from 33b9fcc to b8bd1b8 Compare June 5, 2024 19:28
@rzvxa rzvxa force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from 3482d50 to c71f0fa Compare June 5, 2024 19:30
Copy link

graphite-app bot commented Jun 6, 2024

Merge activity

@Boshen Boshen force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s branch from b8bd1b8 to 91c9995 Compare June 6, 2024 05:42
@Boshen Boshen force-pushed the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch from c71f0fa to ff3f37d Compare June 6, 2024 05:42
@Boshen Boshen changed the base branch from 05-28-improvement_semantic_cfg_better_control_flow_for_dowhilestatement_s to main June 6, 2024 05:48
@graphite-app graphite-app bot merged commit ff3f37d into main Jun 6, 2024
22 checks passed
@graphite-app graphite-app bot deleted the 05-28-improvement_semantic_cfg_better_control_flow_for_forstatement_s branch June 6, 2024 05:48
Boshen pushed a commit that referenced this pull request Jun 13, 2024
Boshen pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant