Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic/cfg): alias petgraph's NodeIndex as BasicBlockId. #3380

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented May 21, 2024

Hides petgraph's general NodeIndex type behind BasicBlockId.

Copy link

graphite-app bot commented May 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels May 21, 2024
Copy link
Contributor Author

rzvxa commented May 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa marked this pull request as ready for review May 21, 2024 22:06
Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #3380 will not alter performance

Comparing 05-22-refactor_semantic_cfg_alias_petgraph_s_nodeindex_as_basicblockid_ (78e6326) with main (40ab95b)

Summary

✅ 27 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 22, 2024
Copy link

graphite-app bot commented May 22, 2024

Merge activity

  • May 21, 11:08 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 21, 11:08 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • May 21, 11:13 PM EDT: Boshen merged this pull request with the Graphite merge queue.

…`. (#3380)

Hides petgraph's general `NodeIndex` type behind `BasicBlockId`.
@Boshen Boshen force-pushed the 05-22-refactor_semantic_cfg_alias_petgraph_s_nodeindex_as_basicblockid_ branch from e0649aa to 78e6326 Compare May 22, 2024 03:09
@graphite-app graphite-app bot merged commit 78e6326 into main May 22, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 05-22-refactor_semantic_cfg_alias_petgraph_s_nodeindex_as_basicblockid_ branch May 22, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants