Add unit test for multi-user configuration loading #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new inspection was created. |
|
💣 Test Failed. 💣 |
|
@owncloud-bot retest this please |
|
@Xenopathic nice idea 👍 |
|
Please mention us in the future so we can get a Github notification 😄 |
|
🚀 Test Passed. 🚀 |
|
@icewind1991 @schiesbn you reviewed the original PR, what do you think of this? |
|
Test case looks good 👍 |
RobinMcCorkell
pushed a commit
that referenced
this pull request
Jul 16, 2014
Add unit test for multi-user configuration loading
|
Do we want to merge this to stable7? |
|
Since it's only a test it should be safe to backport (CC @karlitschek) |
|
yes. please backport |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for getting external storage configurations for multiple users in one session, like used in sharing on external storages. Originally there was a bug, fixed in #8293, so this should prevent any regressions.