Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle return values better from Filesystem::getMountBy* #8285

Merged
merged 1 commit into from
Apr 29, 2014
Merged

Handle return values better from Filesystem::getMountBy* #8285

merged 1 commit into from
Apr 29, 2014

Conversation

RobinMcCorkell
Copy link
Member

getMountByStorageId and getMountByNumericId return an empty array on error, which should be detected to avoid possible errors. This PR also adds in some new logging points and throws to aid debugging

@ghost
Copy link

ghost commented Apr 21, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4374/

@RobinMcCorkell
Copy link
Member Author

@owncloud-bot retest this please

@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues, 1 updated code elements

@ghost
Copy link

ghost commented Apr 21, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4378/

@RobinMcCorkell RobinMcCorkell changed the title Better handle return values from Filesystem::getMountBy* Handle return values better from Filesystem::getMountBy* Apr 21, 2014
@DeepDiver1975
Copy link
Member

Looks good - please review @schiesbn @PVince81

@RobinMcCorkell RobinMcCorkell mentioned this pull request Apr 22, 2014
Merged
Better handle return values from Filesystem::getMountBy*
77e3d06 
getMountByStorageId and getMountByNumericId return an empty array on error,
which should be detected to avoid possible errors. This commit also adds in
some new logging points and throws to aid debugging
@RobinMcCorkell
Copy link
Member Author

Rebased. I noticed part of this change implemented in 2049bed, but I changed count($mounts) into !empty($mounts) to be consistent with the rest of this change.

@ghost
Copy link

ghost commented Apr 25, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4443/

@PVince81
Copy link
Contributor

Looks good, makes sense 👍

@PVince81
Copy link
Contributor

@schiesbn @icewind1991 another review?

@icewind1991
Copy link
Contributor

Looks good 👍

icewind1991 added a commit that referenced this pull request Apr 29, 2014
@icewind1991
Merge pull request #8285 from owncloud/better_getmountby_handling
b95aa43 
Handle return values better from Filesystem::getMountBy*
@icewind1991 icewind1991 merged commit b95aa43 into master Apr 29, 2014
@icewind1991 icewind1991 deleted the better_getmountby_handling branch April 29, 2014 09:22
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RobinMcCorkell @scrutinizer-notifier @DeepDiver1975 @PVince81 @icewind1991