-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove repair steps for broken updater repair" #25343
Conversation
This reverts commit 58ed5b9.
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @nickvergessen and @icewind1991 to be potential reviewers |
Note: I tested this PR locally by patching 9.0.3 and putting it in a local update server and the integrity check issues did disappear after updating. |
@PVince81 I've tried to update via webUI but applying the patch it seems that the open updater button is no longer useful Did you update via CLI or via webUI? |
@davitol I tested with the web update. Maybe something went wrong with your patching and broke the button ? |
@PVince81 version is already checked indirectly by comparing /composer/autoload_classmap.php hash |
// Check the hash for the autoload_classmap.php file, if the hash does match | ||
// the expected value then the third-party folder has already been copied | ||
// properly. | ||
if(hash_file('sha512', $thirdPartyDir . '/composer/autoload_classmap.php') === 'abe09be19b6d427283cbfa7c4156d2c342cd9368d7d0564828a00ae02c435b642e7092cef444f94635f370dbe507eb6b2aa05109b32d8fb5d8a65c3a5a1c658f') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvince this is a version check
@VicDeo so... do you think we can merge this PR ? |
@VicDeo @PVince81 It did not work for me
I'm available in the oC IRC as davitol if it is needed more info. |
Note: no master PR because we still intend to enforce the upgrade path 9.0.x->9.0.4 before providing 9.0.4->9.1 |
@PVince81 Here are the results with the fresh stable9-daily Encryption was enabled for all tests:
9.0.1 -> stable9-daily
9.0.2 -> stable9-daily
9.0.3 -> stable9-daily
P.S. Known issue for 9.0.0 and 9.0.1: |
@VicDeo great! Thanks for testing! CC @owncloud/qa |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This reverts commit 58ed5b9.
Reverts #24438
Fixes owncloud/updater#358
The problem is as follows: whenever that PR was merged, it was assumed that the updater will provide the update path 9.0.x->9.0.2->9.0.3 in which case the repair would happen in 9.0.2.
However, due to another bug that was found later on related to encryption, we can't provide a smooth update path through 9.0.2 for people with encryption.
So this PR reverts the fix to make sure that updates like 9.0.0->9.0.4, 9.0.1->9.0.4 will be possible, skipping 9.0.2.
Now... need to double check whether we should even allow skipping 9.0.2 in the first place.
@VicDeo @DeepDiver1975