Don't keep the full info of all children in memory

[icewind1991]

Improves the memory footprint for the file scanner (30MB -> 5MB for my local test)

Fixes #10954 for the most part

Note, I'm working on additional (less significant) improvements for this issue but those require larger changes and depend on #10993 and are thus not suited for backporting to stable7

cc @DeepDiver1975 @PVince81 @th3fallen

[ghost]

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7569/

[PVince81]

@icewind1991 do I understand this correctly: you moved the loop into a separate function, so the $children will get garbage collected earlier, is that correct ?

[PVince81]

Works 👍

[icewind1991]

do I understand this correctly: you moved the loop into a separate function, so the $children will get garbage collected earlier, is that correct ?

Yes

[bantu]

Memory used by $children variables keeps piling up due to recursion. Seems to make sense.
👍

[icewind1991]

@karlitschek I assume we want to backport this for #10954

[MorrisJobke]

I assume we want to backport this for #10954

As this is a gold ticket: Yes

[MorrisJobke]

stable7 bdc26c6

[karlitschek]

yes please. Thanks guys

[PVince81]

Should we backport this to stable6, to improve #10954 ?
Seems to be low-risk

[karlitschek]

Good idea. Please backport

[PVince81]

Will do

[PVince81]

stable6: c526ebb

Will have a quick test to confirm it still works.

[PVince81]

Scanning still works correctly.