Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong PROPFIND when adding a new sync folder pair #7724

Closed
labkode opened this issue Feb 6, 2020 · 8 comments
Closed

Wrong PROPFIND when adding a new sync folder pair #7724

labkode opened this issue Feb 6, 2020 · 8 comments
Assignees
Labels
p3-medium Normal priority
Milestone

Comments

@labkode
Copy link
Member

labkode commented Feb 6, 2020

When adding a new sync folder pair I copy and paste the path I want to sync however the sync client will issue a PROPFIND to a parent node which I don't have access and it fails.

I only have access to the given path and not to the whole parent nodes.

Screenshot 2020-02-06 at 06 06 14

Can we avoid the sync client to trigger such PROPFIND and only do it on the node that is given (/eos/user/e/xxx/Picture/BMW) ?

The client is the CERNBox branded client, the problem happens since at least version 2.4.3.

@michaelstingl michaelstingl added the p3-medium Normal priority label Feb 24, 2020
@michaelstingl michaelstingl added this to the 2.7.0 milestone Feb 24, 2020
@ogoffart
Copy link
Contributor

ogoffart commented Mar 5, 2020

The problem here is that the client does request as one type in order to open the tree.
The warning is valid: it could not open the tree because of one 403 error.

Should we just not show the warning? Or should there be another wording?

@michaelstingl what's your opinion ?

@labkode
Copy link
Member Author

labkode commented Mar 5, 2020

@ogoffart after pasting the path the propfind to parent should not happen. I understand that if you browse the tree yes, you need to discover the paths (which you don't have access).

So, this message should not be there in the first place.

@ogoffart
Copy link
Contributor

ogoffart commented Mar 5, 2020

When you paste a path, it will still try to open the tree to select the pasted path in the UI.

@labkode
Copy link
Member Author

labkode commented Mar 5, 2020

yes, however the tree is opened in the UI even though you don't have the permissions.

In the example:

/eos/user/e/xxx/Picture/BMW

the sync client only triggers one PROPFIND that fails with 403 to /eos/user/e/xxx/Picture, and not to the other parent directories (/eos, /eos/user, /eos/user/e/, /eos/user/e/xxx/).

@ogoffart
Copy link
Contributor

ogoffart commented Mar 5, 2020

I think it probably does, but only show one warning.

@labkode
Copy link
Member Author

labkode commented Mar 6, 2020

@ogoffart you're right, it does. Can we make the sync client trigger the propfind only for the last element of the path ?

@TheOneRing TheOneRing self-assigned this Jun 23, 2020
@TheOneRing
Copy link
Contributor

@labkode I guess on a normal setup we would want to display the whole tree.
I guess a better solution would be to have a less prominent error, mark the folder in the tree red and provide the error in the tooltip.
Only display the error that prominent on the final folder.

@jnweiger
Copy link
Contributor

jnweiger commented Oct 21, 2020

@iHerrmann77 tried to reproduce, got a crash, fbbf6656-f09a-4151-8309-7c3f7b3b7294

image

Hmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority
Projects
None yet
Development

No branches or pull requests

5 participants