Fix how ovis_json:json_dict_build() use va_arg() #1621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, json_dict_build() recursively calls functions to create a dictionary. It passes a va_list object to the nested function. The function calls va_arg(). According to the va_arg man page, after the function returns, the va_list object is undefined. The patch passes a va_list pointer to its nested function, so the va_list properly moves when the inner function calls va_arg().
|
@tom95858 Please close this pull request if you have already incorporated the change in your branch. |
|
@nichamon, this has been pulled into the multi-instance-wip branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, json_dict_build() recursively calls functions to create a dictionary. It passes a va_list object to the nested function. The function calls va_arg(). According to the va_arg man page, after the function returns, the va_list object is undefined.
The patch passes a va_list pointer to its nested function, so the va_list properly moves when the inner function calls va_arg().