Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[b4.4] static decomposition: yield a config error for "op" without "group" #1520

Closed
wants to merge 1 commit into from
Closed

[b4.4] static decomposition: yield a config error for "op" without "group" #1520

wants to merge 1 commit into from

Conversation

narategithub
Copy link
Collaborator

When "op" was present in the static decomposition configuration but "group" was not defined, the static decomposition skipped row cache creation and continue working with row_cache being NULL. Consequently, when decompose() was later called, ldmsd terminated with SIGSEGV.

This patch add a sanity check in config() so that the static decomposition yields an error when "group" is missing in the presence of "op".

static decomposition: yield a config error for "op" without "group"
9b340b7 
When "op" was present in the static decomposition configuration but
"group" was not defined, the static decomposition skipped row cache
creation and continue working with `row_cache` being `NULL`.
Consequently, when `decompose()` was later called, `ldmsd` terminated
with SIGSEGV.

This patch add a sanity check in `config()` so that the static
decomposition yields an error when "group" is missing in the presence of
"op".
@narategithub
Copy link
Collaborator Author

This PR is for issue #1512 .

@narategithub
Copy link
Collaborator Author

I tested this with the missing "group" in the presence of "op". ldmsd exited due to configuration error as follows:

Thu Nov 14 21:54:37 2024: INFO      : Listening on sock:411 using `sock` transport and `none` authentication
Thu Nov 14 21:54:37 2024: WARNING   : 'interval' is begin deprecated. Please use 'reconnect' with 'prdcr_add' or 'prdcr_start*' in the future.
Thu Nov 14 21:54:37 2024: WARNING   : 'interval' is begin deprecated. Please use 'reconnect' with 'prdcr_add' or 'prdcr_start*' in the future.
Thu Nov 14 21:54:37 2024: ERROR     : store_csv_static_test_sampler: schema "ldms_test_op" requires "group" due to the presence of "op".
Thu Nov 14 21:54:37 2024: ERROR     : msg_no 6: error 22: store_csv_static_test_sampler: schema "ldms_test_op" requires "group" due to the presence of "op".

Thu Nov 14 21:54:37 2024: ERROR     : Configuration error at line 6 (ldmsd.conf)
Thu Nov 14 21:54:37 2024:           : LDMSD_ LDMS Daemon exiting...status 22, Error 22 processing configuration file 'ldmsd.conf'
Thu Nov 14 21:54:37 2024:           : LDMSD_ cleanup end.

@narategithub
Copy link
Collaborator Author

I just found @tom95858 's commit on main that addressed this issue. I'm closing this PR in favor of PR #1521 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom95858 tom95858 Awaiting requested review from tom95858

@morrone morrone Awaiting requested review from morrone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@narategithub