Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail notification and UTF-8 "Title" #5351

Closed
maxatome opened this issue Jul 28, 2020 · 1 comment · Fixed by #5464 or #5472
Closed

Mail notification and UTF-8 "Title" #5351

maxatome opened this issue Jul 28, 2020 · 1 comment · Fixed by #5464 or #5472
Assignees
@fsamin
Labels
bug

Comments

@maxatome
Copy link
Member

If an email notification is created with a Title containing UTF-8 chars, like:

[release 🚀] {{.git.message}}

the encoding is not declared in the Subject header, so the mail reader can not render it correctly:

[release 🚀] …

To avoid doing it by ourselves:

=?UTF-8?Q?[release =f0=9f=9a=80]?= {{.git.message}}

Shouldn't the mail subject be automatically encoded using RFC 2047 if an UTF-8 character is detected?
@yesnault yesnault added the bug label Aug 21, 2020
@fsamin fsamin self-assigned this Sep 30, 2020
fsamin added a commit that referenced this issue Sep 30, 2020
@fsamin
fix(api): support utf8 in mail subject
e657e70 
close #5351

Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@fsamin fsamin mentioned this issue Sep 30, 2020
Merged
fsamin added a commit that referenced this issue Sep 30, 2020
@fsamin
fix(api): support utf8 in mail subject
ebf6e83 
close #5351

Signed-off-by: francois  samin <francois.samin@corp.ovh.com>
@yesnault
Copy link
Member

yesnault commented Oct 2, 2020 •
edited
Loading

reopened
cf. #5464 (review)

on Thunderbird:
Capture d’écran 2020-10-02 à 16 13 07

@yesnault yesnault reopened this Oct 2, 2020
yesnault added a commit that referenced this issue Oct 4, 2020
@yesnault
fix(api): sendmail utf-8
593d3ae 
fix #5351

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault mentioned this issue Oct 4, 2020
Merged
yesnault added a commit that referenced this issue Oct 5, 2020
@yesnault
fix(api): sendmail utf-8 (#5472)
b7205f5 
* fix(api): sendmail utf-8

fix #5351

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsamin fsamin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): support utf8 in mail subject ovh/cds
fix(api): sendmail utf-8 ovh/cds
3 participants
@maxatome @yesnault @fsamin