[Assignment #1]: Basic HTTP Server #3
Conversation
| swagger-ui.sublime-workspace | ||
| .idea | ||
| .project | ||
| node_modules/* |
There was a problem hiding this comment.
You don't need a .gitignore file at every level. The root one above is enough.
…to a better position also created an empty index.js file inside the lib folder to be able to push it
|
|
||
| server.start(function () { | ||
| console.log('Server running at:', server.info.uri); | ||
| }); |
There was a problem hiding this comment.
Super bike sheddy, but I'm a stickler for white space. You might want to add an extra line here.
There was a problem hiding this comment.
Okay I will do it.. but may I suggest we might use EditorConfig to unify the coding style ?
The main repo should have an editorconfig file and this will be reflected to Sublime automatically when you clone or fork the repo
This will help a lot to avoid such mistakes :)
There was a problem hiding this comment.
https://github.com/editorconfig/editorconfig/wiki/Newline-at-End-of-File-Support
Fairly supported and a good idea
Here is an example one we can iterate from if you like --> https://github.com/Famous/famous/blob/develop/.editorconfig
There was a problem hiding this comment.
Standard linting rules for Hapi can be found in Lab https://github.com/hapijs/lab/tree/master/lib/linters
Once tests are added these rules will probably be the standard
There was a problem hiding this comment.
eslint / jscs doesn't create the functionality that an .editorconfig does.
There was a problem hiding this comment.
true but it does add some 'restrictions'
using both is ideal
There was a problem hiding this comment.
Guys, Do I need to do anything more here or it's now fine ?
Also I want to know what to do exactly when the assignment is done, Should you close the pull request or me ?
And when exactly should I consider the assignment as done ?
There was a problem hiding this comment.
Assignment is due 17/3 and your PR will be closed either by being merged or probably be closed by @hueniverse
muhammad-saleh
changed the title
muhammad-saleh
changed the title
| swagger-ui.sublime-workspace | ||
| .idea | ||
| .project | ||
| node_modules/* |
There was a problem hiding this comment.
We like to copy the same ignore file for all hapi project and keep the consistent. Worth looking at hapijs/hapi to see what's in there.
…e actual repo, and in index.js fixed new line after function decalartion also added the package.json object to the internals object also handled error in server.start
| else { | ||
| console.log('Server running at:', server.info.uri); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Add a new line at the end of files
|
Closes #1 |
No description provided.