This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Create basic server #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| var Package = require('../package.json'); | |||
|
|
|||
| module.exports.number = Package.version; | |||
There was a problem hiding this comment.
This extra file doesn't add any value since all it does is load a file and exposes part of it. Better of to just require the package.json file directly. Also, version isn't a number :-)
ivanph
force-pushed
the
master
branch
2 times, most recently
from
bc9a976 to
a7b97cd
Compare
- Adds basic server - Adds /version endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entry for assignment #1