This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Assingment 4 #119
Merged
Assingment 4 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| test: | |||
| @node node_modules/lab/bin/lab -a code | |||
| test-cov: | |||
| @node node_modules/lab/bin/lab -a code -t 100 -L | |||
| @node node_modules/lab/bin/lab -a code -t 100 -Lv --lint-errors-threshold 0 --lint-warnings-threshold 0 | |||
There was a problem hiding this comment.
Are these extra flags really needed?
There was a problem hiding this comment.
Debatable but Imo they will help prevent that the majority of the comments
on pr's are about following the hapi style.
On Fri, 1 May 2015 18:13 Eran Hammer notifications@github.com wrote:
In Makefile
#119 (comment)
:@@ -1,7 +1,7 @@
test:
@node node_modules/lab/bin/lab -a code
test-cov:Are these extra flags really needed?
—
Reply to this email directly or view it on GitHub
https://github.com/hueniverse/hueniversity/pull/119/files#r29511501.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #118
voption to test command because it's easier to see what is going wrong with your tests and since this is a learning thing I thought it might help (it helped me)describeshortcut in test/index.jsServertoHueniversitytest/version.js