Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Parallel test execution #116

Closed
tielur opened this issue Apr 19, 2015 · 1 comment
Closed

Parallel test execution #116

tielur opened this issue Apr 19, 2015 · 1 comment
Assignees
@hueniverse
Labels
bug
Milestone
0.0.3

Comments

@tielur
Copy link

tielur commented Apr 19, 2015

Shouldn't the parallel option set here be false? Lab's default for parallel execution seems to be false but I think the point was to explicitly mark this one as basically not safe for parallel execution if we change the default for the tests to parallel in the future.

As noted here:

When monkey patching code in a test, mark that test with the { parallel: false } lab option to make it both safe for future parallel testing as well as visual cue.
@tielur tielur mentioned this issue Apr 19, 2015
Closed
@hueniverse
Copy link

Yep. I got distracted with other things after I merged it. Master should be up to date now.

@hueniverse hueniverse added the bug label Apr 20, 2015
@hueniverse hueniverse added this to the 0.0.3 milestone Apr 20, 2015
@hueniverse hueniverse self-assigned this Apr 20, 2015
AdriVanHoudt pushed a commit to AdriVanHoudt/hueniversity that referenced this issue Apr 20, 2015
@AdriVanHoudt
Fix parallel flag. Closes outmoded#116
851656f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
bug
Projects
None yet
Milestone
0.0.3
Development

Successfully merging a pull request may close this issue.

set parallel to false when monkey patching
2 participants
@hueniverse @tielur