refactor: combine useConfig and useDatabaseDriver into one context #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage report
Test suite run success60 tests passing in 7 suites. Report generated by 🧪jest coverage report action from 718fc83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first started, we used useDatabaseDriver to pass the database driver deep into child components. Later, as we introduced more features, we also added useConfig to pass various settings down the component tree. These two hooks seem to have overlapping functionality.
This PR merges them into a single context, useStudioContext. This general-purpose context is designed to deliver settings and drivers that need to be propagated deeply into child components.