Skip to content

Remove overrides of PlatformContext #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

reid-spencer
Copy link
Contributor

  • The importation of com.ossuminc.riddl.utils.pc in non test code overrides a user-supplied variant of PlatformContext.
  • To support better platform operations, such uses must be replaced throughout mainline code.

reidspencer added 3 commits November 25, 2024 16:35
* The importation of com.ossuminc.riddl.utils.pc in non test
  code overrides a user-supplied variant of PlatformContext.
* To support better platform operations, such uses must be
  replaced throughout mainline code.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12037960606

Details

  • 4 of 21 (19.05%) changed or added relevant lines in 4 files are covered.
  • 86 unchanged lines in 31 files lost coverage.
  • Overall coverage increased (+0.05%) to 73.387%

Changes Missing Coverage Covered Lines Changed/Added Lines %
passes/shared/src/main/scala/com/ossuminc/riddl/passes/validate/TypeValidation.scala 0 1 0.0%
passes/shared/src/main/scala/com/ossuminc/riddl/passes/validate/BasicValidation.scala 0 3 0.0%
commands/src/main/scala/com/ossuminc/riddl/commands/InfoCommand.scala 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/ContextParser.scala 1 93.75%
passes/shared/src/main/scala/com/ossuminc/riddl/passes/prettify/PrettifyVisitor.scala 1 62.2%
language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/StreamingParser.scala 1 91.8%
language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/ProjectorParser.scala 1 93.75%
language/shared/src/main/scala/com/ossuminc/riddl/language/Messages.scala 1 85.64%
language/shared/src/main/scala/com/ossuminc/riddl/language/parsing/ParsingContext.scala 1 81.82%
passes/jvm/src/main/scala/com/ossuminc/riddl/passes/translate/TranslatingState.scala 1 87.5%
passes/shared/src/main/scala/com/ossuminc/riddl/passes/resolve/ReferenceMap.scala 1 78.13%
passes/shared/src/main/scala/com/ossuminc/riddl/passes/diagrams/DiagramsPass.scala 1 88.39%
commands/src/main/scala/com/ossuminc/riddl/commands/InfoCommand.scala 1 0.0%
Totals Coverage Status
Change from base Build 12037829847: 0.05%
Covered Lines: 4925
Relevant Lines: 6711

💛 - Coveralls

@reid-spencer reid-spencer merged commit 164fdfc into main Nov 26, 2024
2 checks passed
@reid-spencer reid-spencer deleted the eliminate-PlatformContext-overrides branch November 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants