fix null values in static analysis parsing results #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Fisher <maxfisher@google.com>
Signed-off-by: Max Fisher <maxfisher@google.com>
…ointer indirection Signed-off-by: Max Fisher <maxfisher@google.com>
calebbrown
approved these changes
Sep 7, 2023
…f 'file' command doesn't work (#865) Signed-off-by: Max Fisher <maxfisher@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing fails for a file (because it is not JavaScript), the result structs contained null arrays, rather than empty ones. This is inconsistent with typical behaviour for the rest of static analysis.
Also remove unnecessary pointer indirection when storing
parsing.SingleResultin a slice.