Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize plugins into different models #78

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Reorganize plugins into different models #78

merged 2 commits into from
Aug 5, 2022

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Aug 5, 2022 •
edited
Loading

reorganized models with plugins

  • mbari_wec_base: raw model with links and joints
  • mbari_wec: add multiphysics plugins for air spring and EH-PTO
  • mbari_wec_ros: add ros2 controllers

inheritance:
mbari_wec_base -> mbari_wec -> mbari_wec_ros

worlds/mbari_wec.sdf uses mbari_wec_ros and adds the joint_state stuff

@andermi
reorganize plugins into different models
a4b48f8 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi andermi requested review from chapulina and quarkytale August 5, 2022 05:14
chapulina
chapulina reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried running it but the idea LGTM 👍🏽

@andermi
move more plugins from world to ros model
d0b5677 
Signed-off-by: Michael Anderson <anderson@mbari.org>
quarkytale
quarkytale approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@andermi andermi merged commit 18cb783 into main Aug 5, 2022
@andermi andermi deleted the andermi/reorg_model branch August 5, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina left review comments

@quarkytale quarkytale quarkytale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andermi @chapulina @quarkytale