Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PneumaticSpring #11

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Remove PneumaticSpring #11

merged 2 commits into from
Apr 21, 2022

Conversation

chapulina
Copy link
Contributor

@hamilton8415 , this is removing the prototype plugin, let me know if I'm removing too much, or forgetting to remove anything

@chapulina
Remove PneumaticSpring
0297d80 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from hamilton8415 April 18, 2022 22:41
@chapulina chapulina self-assigned this Apr 19, 2022
@chapulina
amerged from main
5961653 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
hamilton8415
hamilton8415 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@hamilton8415 hamilton8415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this plugin was very basic and nothing is lost by deleting these files and making the suggested changes.

@chapulina chapulina merged commit 49783ca into main Apr 21, 2022
@chapulina chapulina deleted the chapulina/rm_spring branch April 21, 2022 15:11
@hamilton8415 hamilton8415 mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamilton8415 hamilton8415 hamilton8415 approved these changes

Assignees

@chapulina chapulina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @hamilton8415