feat!: expedited proposal min deposit param #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
p0mvn
commented
Jun 17, 2022
mattverse
reviewed
Jun 20, 2022
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
mattverse
approved these changes
Jun 20, 2022
johnletey
added a commit
to kyve-org/cosmos-sdk-old
that referenced
this pull request
Jun 21, 2022
johnletey
added a commit
to kyve-org/cosmos-sdk-old
that referenced
this pull request
Jun 21, 2022
johnletey
added a commit
to kyve-org/cosmos-sdk-old
that referenced
this pull request
Jun 27, 2022
* feat: custom proposal-based voting periods (#1) h/t osmosis-labs#239 * feat: expedited proposals (#2) * feat: expedited proposals h/t osmosis-labs#240 * fix: correctly generate random threshold params * fix: update randomised genesis state tests * feat: allow protocol stakers and delegators to vote (#3) * feat: expedited deposits (#4) h/t osmosis-labs#254 * fix: still include custom voting periods * fix: fallback to custom voting periods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1687
What is the purpose of the change
#240 has introduced an expedited proposals feature, allowing the proposals with a shorter voting period to be submitted in case of emergencies.
Based on the feedback from Commonwealth, we would like to also increase the minimum deposit amount for such emergency proposals.
This change introduces the ability to have an expedited minimum deposit amount be managed via parameter.
Brief Changelog
min_expedited_depositfield indeposit_paramsTesting and Verifying
This change added tests and can be verified as follows:
go test -timeout 30s -run ^TestDeposits$ github.com/cosmos/cosmos-sdk/x/gov/keepergo test -timeout 30s -run ^TestProposalGetMinDepositFromParams$ github.com/cosmos/cosmos-sdk/x/gov/typesgo test -timeout 30s -run ^TestHandlerTestSuite$ -testify.m ^(TestProposalHandler)$ github.com/cosmos/cosmos-sdk/x/paramsDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? no