Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map rendering: Elevation markers don't respect units of length settinf #7408

Closed
sgustafso opened this issue Aug 11, 2019 · 11 comments · Fixed by #21948 or #21929
Closed

Map rendering: Elevation markers don't respect units of length settinf #7408

sgustafso opened this issue Aug 11, 2019 · 11 comments · Fixed by #21948 or #21929
Assignees
Labels
Milestone

Comments

@sgustafso
Copy link

Minor issue: Currently the app displays a number next to key features like mountain peaks to indicate the elevation.
However, I noticed that regardless of the configuration of the units of length in the global settings, the map always gives those numbers in units of meters. If you are configured to use miles/feet, the elevation is still given in meters.

This can be a little confusing because the numbers are given without units (there is no 'm' following the elevation number). By contrast, the overlay that shows your current altitude both respects the units of length setting, and indicates the units within the overlay.

@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Aug 15, 2019
@frohro
Copy link

frohro commented Jul 12, 2020

I note the same thing.

@akkana
Copy link

akkana commented Sep 5, 2021

Another vote for this. It's so great to have contour lines in feet (thanks!) that now I'm getting greedy and wanting feature elevations to match the nearby contours. :-)

@vshcherb vshcherb added this to the 4.2-backend milestone Sep 6, 2021
@vshcherb vshcherb removed the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Sep 6, 2021
@vshcherb vshcherb modified the milestones: 4.2-backend, future-backend Apr 25, 2022
@groutr
Copy link

groutr commented Oct 2, 2024

I noticed the same thing in v4.8.5. Is this still an active issue?

@DmitryAlexei
Copy link
Contributor

@groutr The issue is still open, and it is assigned to "Future-backend" milestone

@vshcherb vshcherb changed the title elevation markers don't respect units of length settinf Map rendering: Elevation markers don't respect units of length settinf Oct 3, 2024
@vshcherb vshcherb modified the milestones: future-backend, 4.9-backend Oct 3, 2024
@vshcherb
Copy link
Member

vshcherb commented Oct 3, 2024

@xmd5a2 @ivanPyrohivskyi we need to generate maps with 2 text info and and have internal renderingProperty (feet / km) to display 1 text shield or another. Later UI application will pass that property to rendering engine.

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 29, 2024
@ivanPyrohivskyi ivanPyrohivskyi removed their assignment Nov 5, 2024
@vshcherb vshcherb modified the milestones: 4.9-backend, 5.0-android Nov 5, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Nov 7, 2024
@vshcherb
Copy link
Member

Set to renderingProperty attr="eleUnits" - feet. Test on new maps

@vshcherb vshcherb modified the milestones: 5.0-android, 4.9-android, 5.0-map Nov 28, 2024
@vshcherb vshcherb removed this from the 5.0-map milestone Jan 31, 2025
@vshcherb vshcherb added this to the 5.0-backend milestone Jan 31, 2025
@ivanPyrohivskyi
Copy link
Contributor

@xmd5a2
Copy link
Contributor

xmd5a2 commented Feb 4, 2025

Updated pull request: osmandapp/OsmAnd-resources#1180

@DmitryAlexei
Copy link
Contributor

DmitryAlexei commented Feb 4, 2025

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Feb 5, 2025
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Feb 5, 2025
vshcherb added a commit to osmandapp/OsmAnd-resources that referenced this issue Feb 5, 2025
@Chumva Chumva closed this as completed in 9cd7803 Feb 19, 2025
Chumva added a commit that referenced this issue Feb 19, 2025
@DmitryAlexei DmitryAlexei reopened this Feb 19, 2025
Chumva added a commit that referenced this issue Feb 21, 2025
Chumva added a commit that referenced this issue Feb 21, 2025
This was linked to pull requests Feb 21, 2025
@Zirochkabila
Copy link
Contributor

Zirochkabila commented Feb 26, 2025

Testing 1

Menu > Settings > Chose profile > General settings > Driving region > United States > Go back to the map

Version Details:

  • Android Version: OsmAnd~ 5.0.0#4474m
  • iOS Version: 4982

Issue Description:

  • Data on the map is updated only after restarting OsmAnd.

Severity: Major 🟠

Visual Comparison:

Click to expand
Android Before Restart iOS Before Restart Android After Restart iOS After Restart
Android Before iOS Before Android After iOS After

@Zirochkabila Zirochkabila reopened this Feb 26, 2025
Chumva added a commit that referenced this issue Feb 26, 2025
Chumva added a commit that referenced this issue Feb 26, 2025
@dmpr0
Copy link
Contributor

dmpr0 commented Feb 27, 2025

Review

  • Apply a space as a thousands separator only to numbers with five or more digits (10,000 and above).

@vshcherb vshcherb closed this as completed Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.