Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATM cash_in filter #20574

Closed
Riksu9000 opened this issue Aug 12, 2024 · 6 comments · Fixed by osmandapp/OsmAnd-iOS#4019
Closed

ATM cash_in filter #20574

Riksu9000 opened this issue Aug 12, 2024 · 6 comments · Fixed by osmandapp/OsmAnd-iOS#4019
Assignees
@ivanPyrohivskyi @DmitrySvetlichny
Labels
map-data routing
Milestone
4.9-backend

Comments

@Riksu9000
Copy link
Contributor

Describe the idea (required)

Hi. Having the option to find ATMs that allow depositing cash would be very useful. There are lots of ATMs, but few that accept cash in.

Tell us about the expected behaviour (required)

In the filter screen there would be a checkbox for only showing ATMs with cash_in=yes.

Tell us about alternatives you've considered (required)

There is a payment type filter with lots of random options, including coins and cash, but this tag is not really meant or used for ATMs AFAICT.

Context (optional)

No response
@vshcherb vshcherb added this to the 4.9-map milestone Aug 13, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Aug 14, 2024
@xmd5a2
Add cash_in filter for ATM (osmandapp/OsmAnd#20574)
8576052
@xmd5a2
Copy link
Contributor

xmd5a2 commented Aug 14, 2024 •
edited
Loading

Fixed. Node to test: https://www.openstreetmap.org/node/9586620717
Map: Luxembourg will be regenerated today

@xmd5a2 xmd5a2 closed this as completed Aug 14, 2024
Gh0stz0x added a commit to Gh0stz0x/OsmAnd-Resources that referenced this issue Aug 28, 2024
@Gh0stz0x @xmd5a2
@sonora @njam @MeijiRestored @dmpr0 @breversa @embar- @ivanPyrohivskyi @vshcherb @RZR-UA @alex-osm @matthijskooijman @Kristjan-Ai
Add (#1)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ad07ae7 
* Add icons to routes without name and ref (osmandapp/OsmAnd#19617)

* Add shields for routes without name (osmandapp/OsmAnd#19617)

* Fix tunnels in touring view and LightRS (osmandapp/OsmAnd#20032)

* Touring view: Some code polishing

* Introduce a new road-style "pale" (osmandapp#1085)

* Fixes for osmandapp/OsmAnd#20208

* Fix osmandapp/OsmAnd#20208

* Fix osmandapp/OsmAnd#20208

* Add icons for steps (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* OSM carto style: admin borders & parking spaces (osmandapp#1088)

* admin borders & parking spaces

* admin color attributes

* Added updated 3D Models

* Update fr_tts.js

Differentiate "left/right_keep" and "left/right_bear" + other minor changes

* Add stairs to default rendering mode (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* Fix lt_tts.js by replacing "let" into "var"

Otherwise Lithuanian TTS may not work in OsmAnd

* Add lang support for top_index

* Add turn-lanes-test 85 (Issue #20262) (osmandapp#1092)

* Limit visibility of emergency=access_point (osmandapp/OsmAnd#20230)

* Rename kiev and nordrhein-westfalen (osmandapp/OsmAnd#20323)

* Rename regions (osmandapp/OsmAnd#20323)

* Fix icon (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* Added 3D Model for Car icon

* Fix icon (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* Added 3D Model for Car icon

* Updates for Serbian Lating TTS

* Updates for Serbian Lating TTS

* Avoid traffic_calming=no

* Added updated 3D Models

* Added updated 3D Models

* Hide most icons and some objects for car mode zoom<=17 (osmandapp/OsmAnd#18894)

* Hide house names from car mode (osmandapp/OsmAnd#18894)

* Hide high-level tunnels for all except car mode with hideUnderground option (osmandapp/OsmAnd#20224)

* Prepare data for GPX-approximation tests

* Add Approximation tests round03, round04

* Add sample poiGroup (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)

* Fix turn lanes

* Update fr_tts.js

* Add tests for Issue #19773 vehicle:conditional=no

* Fix lt_tts.js by replacing "let" into "var"

Otherwise Lithuanian TTS may not work in OsmAnd

* Add routing test 70, verify and outdate test 10.1

* Update default.render.xml

* Fixed shields

* Fix blue pentagon road shield

* Revert "Add sample poiGroup (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)"

This reverts commit c4c2251.

* Add test renderingAssociations (shops, transport_car, transport_bicycle) (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)

* Fix

* Check keep instruction after merge turn lanes

* Hide main tunnels in pedestrian and bicycle mode by default (osmandapp/OsmAnd#20224)

* Fix routing

* Add associations (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)

* Fix ford rendering

* Add cash_in filter for ATM (osmandapp/OsmAnd#20574)

* Show cycle routes also at zoom 11/12 (osmandapp#1106)

* Lower minzoom for bicycle routes to 11

* Render cycle routes wider at zoom 11

* Try to fix diet filter (osmandapp/OsmAnd#20583)

* Remove some diet tags because they are already combined to 'diet_*_filter' (osmandapp/OsmAnd#20583)

* Update synthetic test

* Add more rt/roundabout GPX approximation tests (osmandapp#1109)

* Improve tests 68,69 (find exact point-in-segment)

* Updated Gate icons and shields

* ignore tests for now

* Fix tests

* Add svg-web-res to gitignore

* Add current OSM source for Routing_test_68_69

* Update gate icons

* Add vice-versa tests for vehicle:conditional=no

* Revert "Update gate icons"

This reverts commit 6f2c676.

* Ignore test for now

* Ignore test for now

* Added list of travel activities

* Add new Norway regions, fix translations (osmandapp/OsmAnd#20127)

* Add osmand_avalanche_protector=yes tag (osmandapp/OsmAnd#20637)

* Forbid footways and paths for cars (osmandapp/OsmAnd#20117)

* Touring view: Fix highway=road Rendering Issue (#20357)

* Update et_tts.js

Translate some missing strings.
Fixed dictionary keys being passed to tts in distance().

* Update et_tts.js

Added integer declension, fixed bugs

* Update et_tts.js

Bugfixes

* Update et_tts.js

idk

* Update et_tts.js

Fixed language/pronunciation errors.

* Implement OBF-GPX customizations (generation/rendering rules) (osmandapp#1103)

* Support "width" for GPX in OBF files (gen/render)

* Append gpx_icon as additional=true into generation

* Implement OBF-GPX route:point icons customization

* Move OBF-GPX tracks/points to addon (common) style

* Add OBF-GPX track extensions tags to poi_types.xml

* Remove comments and add textDy for OBF-GPX points

* Prettify OBF-GPX track/point tags schema

* Implement OBF-GPX osmand:points_groups tags

---------

Co-authored-by: xmd5a <lornaderek@mail.ru>
Co-authored-by: Hardy <hardy.mueller@web.de>
Co-authored-by: Reto Kaiser <reto@retoonline.com>
Co-authored-by: MeijiRestored <42336759+MeijiRestored@users.noreply.github.com>
Co-authored-by: dmpr0 <dmpr0.ua@gmail.com>
Co-authored-by: breversa <breversa@gmail.com>
Co-authored-by: embar- <embar-@users.noreply.github.com>
Co-authored-by: ivanPyrohivskyi <ivan.pirogovsky@gmail.com>
Co-authored-by: vshcherb <victor.shcherb@gmail.com>
Co-authored-by: RZR-UA <90444451+RZR-UA@users.noreply.github.com>
Co-authored-by: alex-osm <alex.morozov.osm@gmail.com>
Co-authored-by: RZR-UA <youonly@ukr.net>
Co-authored-by: Matthijs Kooijman <matthijs@stdin.nl>
Co-authored-by: Kristjan Arusalu <kristjan.arusalu001@gmail.com>
@DmitryAlexei
Copy link
Contributor

OsmAnd~ 4.9.0#3122m, released: 2024-09-03
49.611830 6.126790
Android version: works fine in POI context menu and in Categories search

2024-09-05.17.47.16.mp4

TestFlight 4.8.3.0 works fine in Categories Search. Search for cash_in=yes through the POI Context menu is slow and shows street names instead of ATMs (ATMs are only shown for a brief moment).

2024-09-05.17.58.49.mp4

@dmpr0
Copy link
Contributor

dmpr0 commented Sep 13, 2024

Review

  • Todo is missing

Sorry, something went wrong.

@dmpr0 dmpr0 reopened this Sep 13, 2024
@vshcherb
Copy link
Member

Bug in iOS with searc

@vshcherb vshcherb reopened this Sep 13, 2024
@vshcherb vshcherb assigned DmitrySvetlichny and unassigned xmd5a2 Sep 13, 2024
@DmitryAlexei DmitryAlexei modified the milestone: 4.9-map Sep 16, 2024
@vshcherb vshcherb modified the milestones: 4.9-map, 4.9-backend Sep 17, 2024
@DmitrySvetlichny
Copy link
Contributor

osmandapp/OsmAnd-iOS#4019

@DmitrySvetlichny DmitrySvetlichny linked a pull request Sep 20, 2024 that will close this issue
ATM cash_in filter fixed osmandapp/OsmAnd-iOS#4019
Merged
@DmitryAlexei
Copy link
Contributor

Fixed
Now the list of ATMs are identical for iOS and Android
49.611830 6.126790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanPyrohivskyi ivanPyrohivskyi

@DmitrySvetlichny DmitrySvetlichny

Labels
map-data routing
Projects
None yet
Milestone
4.9-backend
Development

Successfully merging a pull request may close this issue.

ATM cash_in filter fixed osmandapp/OsmAnd-iOS
7 participants
@ivanPyrohivskyi @vshcherb @xmd5a2 @dmpr0 @Riksu9000 @DmitrySvetlichny @DmitryAlexei