Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ipaddr2 test to use alternative vars for image source #21319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow ipaddr2 test to use alternative vars for image source #21319

wants to merge 1 commit into from

Conversation

BillAnastasiadis
Copy link
Contributor

@BillAnastasiadis BillAnastasiadis commented Mar 3, 2025 •
edited
Loading

This pr enables the ipaddr2 test to alternatively use PUBLIC_CLOUD_IMAGE_LOCATION instead of CLUSTER_OS_VER as the image source.

For the VR I just cloned a 15sp6 job and set the PUBLIC_CLOUD_IMAGE_LOCATION and PUBLIC_CLOUD_STORAGE_ACCOUNT in the clone command

@BillAnastasiadis BillAnastasiadis force-pushed the cloudconfig_adj branch 2 times, most recently from 26b2dcd to a48ecbc Compare March 3, 2025 12:24
@BillAnastasiadis BillAnastasiadis changed the title WIP: Allow ipaddr2 test to use alternative vars for image source Allow ipaddr2 test to use alternative vars for image source Mar 3, 2025
@BillAnastasiadis BillAnastasiadis force-pushed the cloudconfig_adj branch 3 times, most recently from 5d4cb6f to f532f1e Compare March 3, 2025 16:49
alvarocarvajald
alvarocarvajald approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

@a-kpappas a-kpappas Awaiting requested review from a-kpappas a-kpappas is a code owner

@Amrysliu Amrysliu Awaiting requested review from Amrysliu Amrysliu is a code owner

@emiura emiura Awaiting requested review from emiura emiura is a code owner

@jankohoutek jankohoutek Awaiting requested review from jankohoutek jankohoutek is a code owner

@lilyeyes lilyeyes Awaiting requested review from lilyeyes lilyeyes is a code owner

@lpalovsky lpalovsky Awaiting requested review from lpalovsky lpalovsky is a code owner

@mpagot mpagot Awaiting requested review from mpagot mpagot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillAnastasiadis @alvarocarvajald