Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCI: Softfail when BCI softfails #21304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BCI: Softfail when BCI softfails #21304

wants to merge 1 commit into from
+21 −3

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Feb 27, 2025 •
edited
Loading

grisu48
grisu48 reviewed Feb 27, 2025
View reviewed changes
tests/containers/bci_logs.pm Outdated
@@ -47,6 +50,15 @@ sub run {
# Replace default attribute name "pytest" by its env name and engine
my $new_name = $env . '_' . $engine;
$node->{name} =~ s/pytest/$new_name/;
for my $case ($node->findnodes('//testcase')) {
for my $skipped ($case->findnodes('//skipped')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skipped ones don't matter, they should not be softfailed.

We should look for the softfailed entries, or xfail(ed) as they are in the pytest environment.

@pdostal pdostal added the blocked Blocked from another task label Feb 28, 2025
@pdostal pdostal mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grisu48 grisu48 grisu48 left review comments

@mloviska mloviska Awaiting requested review from mloviska mloviska is a code owner

@ricardobranco777 ricardobranco777 Awaiting requested review from ricardobranco777 ricardobranco777 is a code owner

@rbmarliere rbmarliere Awaiting requested review from rbmarliere

Assignees
No one assigned
Labels
blocked Blocked from another task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdostal @grisu48