Restore the original system config and restart NetworkManager-wait-online.service #21298
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinawang123
requested review from
mloviska,
ricardobranco777 and
rbmarliere
as code owners
rfan1
reviewed
Feb 27, 2025
tests/microos/networkmanager.pm
Outdated
| @@ -40,6 +40,8 @@ sub restore_config { | |||
| script_run('rm -f /etc/NetworkManager/conf.d/00-use-dnsmasq.conf'); | |||
| script_run('unlink /etc/resolv.conf'); | |||
| systemctl('restart NetworkManager'); | |||
| sleep 30; | |||
There was a problem hiding this comment.
I suggest using script_retry here
tinawang123
added
qe-core
mloviska
reviewed
Mar 3, 2025
| @@ -40,6 +40,7 @@ sub restore_config { | |||
| script_run('rm -f /etc/NetworkManager/conf.d/00-use-dnsmasq.conf'); | |||
| script_run('unlink /etc/resolv.conf'); | |||
| systemctl('restart NetworkManager'); | |||
| script_retry('systemctl restart NetworkManager-wait-online.service', retry => 3, delay => 20); | |||
There was a problem hiding this comment.
Just out of curiosity, have you checked nm-online? You can set timeout over there and most likely you might receive some useful output in case of failure.
There was a problem hiding this comment.
Yes, I checked nm-online, it failed to start after NM started.
I have discussed with developer, and opened one bug: https://bugzilla.suse.com/show_bug.cgi?id=1238218
There was a problem hiding this comment.
In this case, I believe that relying on NetworkManager-wait-online.service as it executes nm-online is not the right check to make sure that NM has started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the original system config and restart NetworkManager-wait-online.service