-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render autoinst url from openQA url #21292
base: master
Are you sure you want to change the base?
Render autoinst url from openQA url #21292
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
1dc24c6
to
1ba68ee
Compare
1ba68ee
to
dea269b
Compare
@alice-suse @guoxuguang @Julie-CAO @RoyCai7 @nanzhg @tbaev Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Has this test used the cached Rendered autoinst url? I'd like to see how it is presented but I failed to find the "Record_info" in screenshots? |
It does not use resoures in assets/hdd |
dea269b
to
6291a23
Compare
So is it usually applied for tests with SLM guests, or future SLE16 guests, which need .qcow2 files? and nothing to be done on openqa settings for our current tests? |
1.New subroutine render_autoinst_url in lib/utils.pm to render autoinst url from openQA, in order to avoid direct downloading from openQA instance. 2.Replace direct openQA address with rendered autoinst url in lib/guest_installation_and_configuration_base.pm.
6291a23
to
06b0f1a
Compare
For those using resources assets/.hdd. Nothing to be changed. |
Get it. Thanks for the fix. LGTM |
New subroutine
render_autoinst_url
inlib/utils.pm
to render autoinst url from running openQA, in order to avoid direct downloading from openQA instance.Replace direct openQA address with rendered autoinst url in
lib/guest_installation_and_configuration_base.pm
.Verification Runs: