Add new Business One installer #21257
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds necessary changes to support 2411 SAP Business One Installer. Fixes: TEAM-10112 (Update Business One Installer to 2411) VR
emiura
requested review from
a-kpappas,
alvarocarvajald,
Amrysliu,
BillAnastasiadis,
jankohoutek,
lilyeyes,
lpalovsky and
mpagot
as code owners
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
| @@ -1040,8 +1040,8 @@ Package and upload HANA installation logs from SUT. | |||
| =cut | |||
|
|
|||
| sub upload_hana_install_log { | |||
| my @hana_logs = qw(/var/adm/autoinstall/logs /var/tmp/hdb*); | |||
| push(@hana_logs, "/var/log/SAPBusinessOne/B1Installer*") if get_var('BONE'); | |||
| my @hana_logs = qw("/var/adm/autoinstall/logs" "/var/tmp/hdb"); | |||
There was a problem hiding this comment.
Double quotes are not necessary inside qw() (quote word); if used the elements will contain the quotes:
# perl
@l = qw("/var/adm/autoinstall/logs" "/var/tmp/hdb");
use Data::Dumper;
print Dumper \@l;
$VAR1 = [
'"/var/adm/autoinstall/logs"',
'"/var/tmp/hdb"'
];
As the following line is not adding the quotes, I don't think the quotes are necessary in the definition with qw().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds necessary changes to support 2411 SAP Business One Installer.
Fixes:
TEAM-10112 (Update Business One Installer to 2411)
VR
[type description here, PLEASE, REMOVE THIS LINE, PLACEHOLDER, BEFORE SUBMITTING THIS PULL REQUEST]