[Kratos dotnet SDK] VerifiableAddress.VerifiedAt is null

[sergeyshaykhullin]

I tried to call /whoami with dotnet SDK client. In client definition VerifiedAt is non nullable, but api returted null

1. Model
   
2. Response
   
3. Exception
   

I think it is can be a swagger misconfiguration?

[sergeyshaykhullin]

Same not-null in java client https://github.com/ory/sdk/blob/master/clients/kratos/java/src/main/java/sh/ory/kratos/model/VerifiableAddress.java. But kratos api can return null

[sergeyshaykhullin]

I checked swagger schema, verified_at is NullTime. I think it is ok and need some generator hacks

[sergeyshaykhullin]

Seems like OpenAPITools/openapi-generator#4816 OpenAPITools/openapi-generator#3725

[sergeyshaykhullin]

@aeneasr I think that NullTime might be marked as nullable: true or x-nullable: true (it might not work)

Some conditions for property nullability:
https://github.com/OpenAPITools/openapi-generator/pull/3537/files
https://github.com/OpenAPITools/openapi-generator/blob/2331432cc0f062ceff44c3d09e1a16c31abf6f57/modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java#L1419

[sergeyshaykhullin]

Interesting...
Ts client has nullable verified_at

sdk/clients/kratos/typescript/api.ts

Line 1045 in 00fc86e

verified_at?: string;

[aeneasr]

We are moving to OpenAPI 3.0 which hopefully improves this situation. However, it is also possible that the generator is buggy for the language.

[afreakk]

I am still having this issue, with

<PackageReference Include="Ory.Kratos.Client" Version="0.7.6-alpha.7" />

Error converting value {null} to type 'System.DateTime'. Path 'identity.verifiable_addresses[0].verified_at', line 1, position 615.

(also the exceptionfactory here seems to produce null exception, so the function doesnt throw like it probably should, I just get null response from toSession, had to step into the function to spot the actual exception

        Exception exception = this.ExceptionFactory("ToSession", (IApiResponse) apiResponse);
        if (exception != null)
          throw exception;

)

(From KratosVerifiableIdentityAddress.cs

    /// <summary>Gets or Sets VerifiedAt</summary>
    /// <footer><a href="https://www.google.com/search?q=Ory.Kratos.Client.Model.KratosVerifiableIdentityAddress.VerifiedAt">`KratosVerifiableIdentityAddress.VerifiedAt` on google.com</a></footer>
    [DataMember(EmitDefaultValue = false, Name = "verified_at")]
    public DateTime VerifiedAt { get; set; }

)

Seems this will be fixed in kratos v0.8? ory/kratos#1736

[aeneasr]

Kratos 0.8 is being released today (pipeline is running). Hopefully it gets fixed then. Maybe you can comment and keep us updated? :)

[afreakk]

Yes it worked without issues in 0.8 👍

[aeneasr]

wohooo!