-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): remove references of tj-actions #1097
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
=======================================
Coverage 41.47% 41.47%
=======================================
Files 21 21
Lines 1811 1811
=======================================
Hits 751 751
Misses 1060 1060
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Seems smart. I have several project affected by secrets exfiltrated by his changed-files action. Having reviewed the current situation I think it's probably fair to note:
Overall even if there isn't a currently active attack in progress I think not trusting this actor's work without verifying and pinning and not broadly recommending their actions for use is probably a good idea until they demonstrate some better practices and more actual transparency. |
Exactly. Good points. I should also check the other 3rd party GitHub actions at some point and verify that they are following good security practices. |
A more productive approach here would be to contribute to the project. Security attacks are very common in software, and trusting the project or its owner without concrete suggestions for improvements does nothing to enhance the quality of the project. Oddly, this issue isn’t a reflection of poor security practices; rather, it highlights the resources available to open-source developers, both financially and in terms of community support. |
@orhun This same attack also hit reviewdog/reviewdog#2079. |
Good to know @jackton1 - I just checked and none of my repos use actions from that organization, so we should be safe, I hope :D |
There is some drama surrounding the tj-actions organization on GitHub and I am removing their
git-cliff
action from the documentation until this is resolved: tj-actions/git-cliff#74