Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.1.0 rc1 #1010

Closed
wants to merge 2 commits into from
Closed

Release v1.1.0 rc1 #1010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bfb87
version: bump for release of v1.1.0-rc1
sajayantony Jul 6, 2023
2db687c
version: bump HEAD back to +dev
sajayantony Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package version

var (
// Version is the current version of the oras.
Version = "1.1.0-rc.1"
Version = "1.1.0-rc1+dev"
// BuildMetadata is the extra build time data
BuildMetadata = "unreleased"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sajayantony We already have extra build time data here, the full version is <Version>+<BuildMetadata>
e.g.

  • if you build from this commit, the full version string will be 1.1.0-rc1+dev+unreleased.
  • Without this code change in this PR, the full version string will be 1.1.0-rc.1+unreleased, the latter already implies the former with less duplicated info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition quotes from SemVer 2.0.0:

  1. Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Build metadata MUST be ignored when determining version precedence. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3----117B344092BD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shizhMSFT should we up the version then?

Copy link
Contributor

@qweeah qweeah Jul 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version for this release is already updated in 42650e5 before the branch cut. @sajayantony Are you suggesting we should do the version update for the next release version? We don't have a procedure for that and might be worth doing after releasing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reset the releasing pipeline of v1.1.0-rc.1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See details in #1013

// GitCommit is the git sha1
Expand Down