feat!: retryable http client

[souleb]

fixes #147

If implemented, this will provide a default http client with retry.

The retry function is an exponential back off 0.25s * 2^n ± 10% and max 5 attempts.

The client is the default client of auth.Client

Co-authored-by: Shiwei Zhang shizh@microsoft.com
Signed-off-by: Soule BA bah.soule@gmail.com

cc @shizhMSFT

[shizhMSFT]

Good work. Just left some initial review comments. I will continue reviewing later.

[souleb]

The examples tests are failing due to some TLS misconfiguration when I set the retry.DefaultClient as client for auth.Client. Can you tell me where to look?

[shizhMSFT]

The examples tests are failing due to some TLS misconfiguration when I set the retry.DefaultClient as client for auth.Client. Can you tell me where to look?

@souleb The root cause of the error is that retry.Client relies on the default http transport. Therefore, we need to override the default http transport instead of the client for the mocks.

Please check the following changes:

diff --git a/example_test.go b/example_test.go
index c1e4c20..82fa126 100644
--- a/example_test.go
+++ b/example_test.go
@@ -182,7 +182,7 @@ func TestMain(m *testing.M) {
                panic(err)
        }
        remoteHost = u.Host
-       http.DefaultClient = httpsServer.Client()
+       http.DefaultTransport = httpsServer.Client().Transport
 
        os.Exit(m.Run())
 }
diff --git a/registry/example_test.go b/registry/example_test.go
index 70f102c..2463667 100644
--- a/registry/example_test.go
+++ b/registry/example_test.go
@@ -65,7 +65,7 @@ func TestMain(m *testing.M) {
                panic(err)
        }
        host = u.Host
-       http.DefaultClient = ts.Client()
+       http.DefaultTransport = ts.Client().Transport
 
        os.Exit(m.Run())
 }
diff --git a/registry/remote/example_test.go b/registry/remote/example_test.go
index bbd292e..370486d 100644
--- a/registry/remote/example_test.go
+++ b/registry/remote/example_test.go
@@ -214,7 +214,7 @@ func TestMain(m *testing.M) {
                panic(err)
        }
        host = u.Host
-       http.DefaultClient = ts.Client()
+       http.DefaultTransport = ts.Client().Transport
 
        os.Exit(m.Run())
 }

[codecov-commenter]

Codecov Report

Merging #398 (afe215f) into main (76382aa) will increase coverage by 0.02%.
The diff coverage is 72.63%.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   72.31%   72.34%   +0.02%     
==========================================
  Files          46       48       +2     
  Lines        4349     4444      +95     
==========================================
+ Hits         3145     3215      +70     
- Misses        903      921      +18     
- Partials      301      308       +7     

Impacted Files	Coverage Δ
registry/remote/auth/client.go	72.46% <ø> (+0.40%)	⬆️
registry/remote/retry/client.go	66.66% <66.66%> (ø)
registry/remote/retry/policy.go	79.54% <79.54%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[shizhMSFT]

LGTM

[Wwwsylvia]

LGTM