Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: update the type of Concurrency options to int #376

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

Wwwsylvia
Copy link
Member

BREAKING CHANGE: Changed the type of Concurrency options to int from int64

Resolves #375
Signed-off-by: Lixia (Sylvia) Lei lixlei@microsoft.com

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from shizhMSFT December 7, 2022 04:11
@codecov-commenter
Copy link

Codecov Report

Merging #376 (5f73bfe) into main (ff05195) will decrease coverage by 0.30%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   72.24%   71.94%   -0.31%     
==========================================
  Files          42       43       +1     
  Lines        4093     4095       +2     
==========================================
- Hits         2957     2946      -11     
- Misses        855      868      +13     
  Partials      281      281              
Impacted Files Coverage Δ
internal/syncutil/limitgroup.go 0.00% <0.00%> (ø)
content.go 74.55% <100.00%> (-1.20%) ⬇️
copy.go 60.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 275b940 into oras-project:main Dec 7, 2022
@Wwwsylvia Wwwsylvia deleted the int branch December 8, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the type of Concurrency options to int from int64
3 participants