Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt range query only if server explicitly supports #369

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

shizhMSFT
Copy link
Contributor

Fixes #368

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT requested a review from Wwwsylvia December 2, 2022 09:45
@codecov-commenter
Copy link

Codecov Report

Merging #369 (a9b9116) into main (511e4d4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   72.24%   72.20%   -0.04%     
==========================================
  Files          42       42              
  Lines        4100     4098       -2     
==========================================
- Hits         2962     2959       -3     
- Misses        856      857       +1     
  Partials      282      282              
Impacted Files Coverage Δ
registry/remote/repository.go 68.43% <100.00%> (-0.07%) ⬇️
internal/syncutil/merge.go 69.64% <0.00%> (-1.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Wwwsylvia
Copy link
Member

Should FetchReference apply the same?

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 7dcd097 into oras-project:main Dec 2, 2022
@shizhMSFT shizhMSFT deleted the shizh/range branch December 2, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob fetch should not attempt range request by default
3 participants