Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support creating read-only OCI store from fs.FS #367

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Dec 1, 2022

Will support creating OCI store from tarball in next PR.

Resolves: #336
Signed-off-by: Lixia (Sylvia) Lei lixlei@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #367 (8c067fa) into main (253d5ec) will increase coverage by 0.20%.
The diff coverage is 77.00%.

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   71.84%   72.05%   +0.20%     
==========================================
  Files          43       45       +2     
  Lines        4103     4172      +69     
==========================================
+ Hits         2948     3006      +58     
- Misses        870      877       +7     
- Partials      285      289       +4     
Impacted Files Coverage Δ
content/oci/oci.go 65.64% <ø> (ø)
registry/reference.go 68.42% <ø> (ø)
registry/remote/registry.go 67.41% <ø> (ø)
registry/remote/repository.go 68.22% <ø> (ø)
registry/repository.go 0.00% <ø> (ø)
content/oci/readonlyoci.go 66.12% <66.12%> (ø)
content/oci/readonlystorage.go 93.93% <93.93%> (ø)
content/oci/storage.go 63.76% <100.00%> (+1.66%) ⬆️
internal/syncutil/merge.go 71.42% <0.00%> (+1.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 04d11f9 into oras-project:main Dec 8, 2022
@Wwwsylvia Wwwsylvia deleted the oci_fs branch December 8, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor content/oci with fs.FS
3 participants