Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix potential deadlock in oras.Copy #359

Merged
merged 11 commits into from
Nov 9, 2022

Conversation

Wwwsylvia
Copy link
Member

  1. Refactored copyGraph and internal graph utilities
  2. Added a test case that could cause dead locks

Fixes #349
Signed-off-by: Lixia (Sylvia) Lei lixlei@microsoft.com

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #359 (5362755) into main (7ee86b9) will decrease coverage by 0.69%.
The diff coverage is 34.61%.

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   72.52%   71.82%   -0.70%     
==========================================
  Files          38       39       +1     
  Lines        3945     3989      +44     
==========================================
+ Hits         2861     2865       +4     
- Misses        805      844      +39     
- Partials      279      280       +1     
Impacted Files Coverage Δ
internal/syncutil/limit.go 0.00% <0.00%> (ø)
copy.go 60.71% <65.85%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 9e5b141 into oras-project:main Nov 9, 2022
@Wwwsylvia Wwwsylvia deleted the fix_copy branch November 9, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Potential dead lock in oras.Copy
3 participants