Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise doc of registry.Reference #358

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

nima
Copy link
Contributor

@nima nima commented Nov 8, 2022

Closes #332

@shizhMSFT shizhMSFT changed the title fix: Reference struct's annotation; closes #332 doc: revise doc of registry.Reference Nov 10, 2022
@shizhMSFT
Copy link
Contributor

@nima I've updated PR title and description for you. You may follow the same pattern for future PRs.

nima added a commit to nima/oras-go that referenced this pull request Nov 10, 2022
This change closes oras-project#332 and oras-project#358.

Signed-off-by: Nima Talebi <ntd@amazon.com>
nima added a commit to nima/oras-go that referenced this pull request Nov 10, 2022
This change closes oras-project#332 and oras-project#358.

Signed-off-by: Nima Talebi <ntd@amazon.com>
Signed-off-by: Nima Talebi <ntd@amazon.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 74eeb52 into oras-project:main Nov 11, 2022
@shizhMSFT
Copy link
Contributor

Thank @nima for contributing. The doc will be auto updated soon at https://pkg.go.dev/oras.land/oras-go/v2@main/registry#Reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the documentation of registry.Reference
2 participants