fix: add nil checks for some functions #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 72.42% 72.46% +0.04%
==========================================
Files 38 38
Lines 3615 3621 +6
==========================================
+ Hits 2618 2624 +6
Misses 738 738
Partials 259 259
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
reviewed
Sep 20, 2022
Wwwsylvia
reviewed
Sep 20, 2022
Wwwsylvia
requested changes
Sep 20, 2022
…asmine/nilCheck
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
shizhMSFT
requested changes
Sep 22, 2022
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
…asmine/nilCheck
Wwwsylvia
reviewed
Sep 22, 2022
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
…asmine/nilCheck
shizhMSFT
reviewed
Sep 22, 2022
extendedcopy.go
Outdated
Comment on lines
181
to
186
| // - If key is available in the predecessor's annotation and regex is not nil, | ||
| // return the predecessor if the annotation value matches the regex. | ||
| // - If key is available in the predecessor's annotation and regex is nil, | ||
| // return the predecessor. | ||
| // - If key is unavailable in the predecessor's annotation, the predecessor | ||
| // will not be returned. |
There was a problem hiding this comment.
A predecessor is kept if the key is in its annotation and matches the regex if present.
Signed-off-by: JasmineTang <jasminetang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
nilchecks for functionsoras.WithTargetPlatform,oras.FilterAnnotationandoras.FilterArtifactType.Resolves #318
Signed-off-by: JasmineTang jasminetang@microsoft.com