Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Repository.Manifest() now returns a ManifestStore #300

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

Wwwsylvia
Copy link
Member

Resolves #284

Signed-off-by: Sylvia Lei lixlei@microsoft.com

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from shizhMSFT September 6, 2022 07:38
@Wwwsylvia Wwwsylvia changed the title feat: Repository.Manifest() returns a ManifestStore feat: Repository.Manifest() now returns a ManifestStore Sep 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #300 (a9cee9c) into main (e413b92) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   71.54%   71.57%   +0.03%     
==========================================
  Files          37       37              
  Lines        3511     3515       +4     
==========================================
+ Hits         2512     2516       +4     
  Misses        747      747              
  Partials      252      252              
Impacted Files Coverage Δ
registry/repository.go 0.00% <ø> (ø)
registry/remote/repository.go 65.72% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 9a92908 into oras-project:main Sep 6, 2022
@Wwwsylvia Wwwsylvia deleted the manifeststore branch September 19, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reviewing Repository Interface
3 participants