Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "Upload empty blob when packing" #295

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Sep 5, 2022

Reverts #262
Fixes #294

Signed-off-by: Sylvia Lei lixlei@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #295 (ffd4a34) into main (6d3ce22) will increase coverage by 0.04%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   71.20%   71.24%   +0.04%     
==========================================
  Files          37       37              
  Lines        3480     3485       +5     
==========================================
+ Hits         2478     2483       +5     
  Misses        749      749              
  Partials      253      253              
Impacted Files Coverage Δ
pack.go 81.05% <87.50%> (+1.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This reverts commit 069da31.

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia force-pushed the revert-262-pack_empty branch from f7eb445 to 7e15cc0 Compare September 5, 2022 02:57
@Wwwsylvia Wwwsylvia changed the title Revert "Upload empty blob when packing" fix: Revert "Upload empty blob when packing" Sep 5, 2022
@Wwwsylvia Wwwsylvia requested a review from shizhMSFT September 5, 2022 04:13
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit faf6320 into main Sep 5, 2022
@shizhMSFT shizhMSFT deleted the revert-262-pack_empty branch September 5, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAR (Google Artifact Registry) won't accept empty blob
4 participants