Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove +json encoding from the default config media type #288

Merged
merged 1 commit into from
Sep 1, 2022
Merged

fix: remove +json encoding from the default config media type #288

merged 1 commit into from
Sep 1, 2022

Conversation

Wwwsylvia
Copy link
Member

Resolves #285
Signed-off-by: Sylvia Lei lixlei@microsoft.com

@Wwwsylvia
remove +json encoding from the default config media type
bf633e2 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 59befb3 into oras-project:main Sep 1, 2022
@Wwwsylvia Wwwsylvia deleted the mediatype branch September 1, 2022 09:01
shizhMSFT added a commit that referenced this pull request Sep 5, 2022
@shizhMSFT
Revert "fix: remove +json encoding from the default config media ty…
462a51d 
…pe (#288)"

This reverts commit 59befb3.
Wwwsylvia pushed a commit that referenced this pull request Sep 5, 2022
@shizhMSFT @Wwwsylvia
Revert "fix: remove +json encoding from the default config media ty…
19bfedf 
…pe (#288)"

This reverts commit 59befb3.

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Wwwsylvia added a commit that referenced this pull request Sep 5, 2022
@Wwwsylvia
Revert "fix: remove +json encoding from the default config media ty…
e68d560 
…pe (#288)"

This reverts commit 59befb3.
Wwwsylvia added a commit that referenced this pull request Sep 5, 2022
@Wwwsylvia
Revert "fix: remove +json encoding from the default config media ty…
4558934 
…pe (#288)"

This reverts commit 59befb3.

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 5, 2022
Merged
shizhMSFT pushed a commit that referenced this pull request Sep 5, 2022
@Wwwsylvia
Revert "fix: remove +json encoding from the default config media ty…
e3e46b0 
…pe (#288)" (#297)

This reverts commit 59befb3.

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default mediatype should not include encoding
2 participants
@Wwwsylvia @shizhMSFT