feat!: support oras.Fetch and oras.FetchBytes
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 70.87% 70.97% +0.10%
==========================================
Files 37 37
Lines 3368 3421 +53
==========================================
+ Hits 2387 2428 +41
- Misses 734 743 +9
- Partials 247 250 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Wwwsylvia
changed the title
Wwwsylvia
commented
Aug 30, 2022
Wwwsylvia
commented
Aug 31, 2022
| } | ||
|
|
||
| // FetchBytes fetches the content bytes identified by the reference. | ||
| func FetchBytes(ctx context.Context, target ReadOnlyTarget, reference string, opts FetchBytesOptions) (ocispec.Descriptor, []byte, error) { |
There was a problem hiding this comment.
Any naming suggestions are welcomed!
Wwwsylvia
changed the title
Wwwsylvia
changed the title
oras.Fetch and oras.FetchBytes
Wwwsylvia
changed the title
oras.Fetch and oras.FetchBytesoras.Fetch and oras.FetchBytes
lizMSFT
reviewed
Aug 31, 2022
shizhMSFT
reviewed
Sep 1, 2022
shizhMSFT
reviewed
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility methods for convenient content fetching.
Resolves #272
BREAKING CHANGE: Move
content.ErrSizeExceedLimittoerrdef.ErrSizeExceedsLimitSigned-off-by: Sylvia Lei lixlei@microsoft.com